Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line: use data domain to get media and menu content #557

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

chentsulin
Copy link
Member

@chentsulin chentsulin commented Apr 8, 2020

To avoid the domain name breaking changes introduced by LINE, port those changes into v0.7.x for Bottender v0.15.x.

#550
Change the endpoint of api call in the following methods:

  • LineClient#getMessageContent
  • LineClient#uploadRichMenuImage
  • LineClient#downloadRichMenuImage

@chentsulin chentsulin requested a review from etrex April 8, 2020 05:00
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #557 into v0.7.x will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.7.x     #557      +/-   ##
==========================================
+ Coverage   97.52%   97.54%   +0.01%     
==========================================
  Files          13       13              
  Lines         930      936       +6     
  Branches      124      124              
==========================================
+ Hits          907      913       +6     
  Misses         22       22              
  Partials        1        1              
Impacted Files Coverage Δ
packages/messaging-api-line/src/LineClient.js 99.24% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9865164...c0a86db. Read the comment docs.

@chentsulin chentsulin merged commit c2ec7e8 into v0.7.x Apr 8, 2020
@chentsulin chentsulin deleted the data-domain-0.7.x branch April 8, 2020 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants