Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path_shift fall back always triggering #1034

Closed
wants to merge 1 commit into from

Conversation

Voultapher
Copy link

Instead of always doing a negative root path shift,
even after a successful return, only catch exceptions.

Instead of always doing a negative root path shift,
even after a successful return, only catch exceptions.
@Voultapher
Copy link
Author

@defnull the last time this was changed, is 7 years ago by you. I fail to understand why doing request.path_shift(-path_depth) even after a successful return could be the wanted behavior. Can you please shine some light on this.

@defnull
Copy link
Member

defnull commented Feb 14, 2018

If I remember correctly, because after_request handlers installed to the parent app should see the original state, not the modified one.

@Voultapher
Copy link
Author

Ok, let me see if I can come up with a test for it.

@Voultapher
Copy link
Author

The use case no longer matters for me so I'm closing this.

@Voultapher Voultapher closed this Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants