Fix X-Forwarded-Host when multiple proxies, see PR#928 #1109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See initial bugreport in the PR #928
This should fix the case where bottle is behind multiple reverse-proxy, and each proxy is adding its own X-Forwarded-Host.
When the request arrives at the bottle level, we have multiple values in
X-Forwarded-Host: www.foo.com, xyz.foo.local
. It makes any uses ofrequest.url
/bottle functions
not possible.E.g.
With
X-Forwarded-Host: www.foo.com, xyz.foo.local
given:Before the patch:
request.url == 'http://www.foo.com, xyz.foo.local/index.html'
After the patch:
request.url == 'http://www.foo.com/index.html'