Add support for non-empty requests with no Content-Length header. #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some situations, a non-empty non-chunked request may lack a Content-Length header and still be valid: - HTTP/1.0 clients (default to 'Connection: close') - HTTP/1.1 clients with 'Connection: close' - WSGI server transparently decoding 'Transfer-Encoding: chunked' - WSGI middleware filtering the request body (e.g. gzip) In all these situations, 'wsgi.input' MUST NOT read across request boundaries and terminate at the end of the request body, because WSGI defines no other way to detect the end of the stream. Most WSGI servers or filtering middleware correctly set 'wsgi.input' to a limiting wrapper. They MAY signal this via the non-standard 'wsgi.input_terminated' flag, but since not limiting 'wsgi.input' would be clearly wrong, we can assume support for 'wsgi.input_terminated' (or 'Connection: close', which has the same effect) even if the flag is not set. This patch will cause bottle to read from 'wsgi.input' until it returns no more bytes if 'Content-Length' is not set. It will also throw an error if 'Content-Length' is set, but less than the expected number of bytes can be read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, a non-empty non-chunked request may lack a
Content-Length header and still be valid:
In all these situations, 'wsgi.input' MUST NOT read across
request boundaries and terminate at the end of the request body,
because WSGI defines no other way to detect the end of the stream.
Most WSGI servers or filtering middleware correctly set 'wsgi.input'
to a limiting wrapper. They MAY signal this via the non-standard
'wsgi.input_terminated' flag, but since not limiting 'wsgi.input'
would be clearly wrong, we can assume support for 'wsgi.input_terminated'
(or 'Connection: close', which has the same effect) even if the flag
is not set.
This patch will cause bottle to read from 'wsgi.input' until it returns
no more bytes if 'Content-Length' is not set. It will also throw an error
if 'Content-Length' is set, but less than the expected number of bytes can
be read.