New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing Python 2 support from 0.13 #1193
base: master
Are you sure you want to change the base?
Conversation
91cc5f1
to
337384f
Compare
Since Bottle-0.12 will be the last release supporting Python 2 (2.5+ actually) and very old versions of Python 3 (3.2+), it will become an LTS release and will be maintained (security patches only) for a bit longer than usual. This allows us to drop support for old python versions without hurting existing users too much. I'm thinking about skipping 0.13 and move forward to 0.14 in a single step to make it more clear that there are breaking changes this time. Spamming all 0.12/Py2 users with a deprecation warning is a bit too much I think. Some people can't update, even if they want to. |
@defnull this is very welcome. According to your own roadmap the aren't many blocking issues for 0.13. but it's been so long since the first map was written I'm not sure it's even relevant. |
Also remember to remove unsupported targets from the root Makefile. |
The release-0.12 branch has its own Makefile and test suite. We can remove any trace of 2.7 or 3.4 support from the master branch. |
It has been a year... Conflicts. |
Yes, it probably wasn't the best idea to start with this before 2.7 is actually EOL and expect that there are no conflicts. |
All declarations like
may be reduced to
|
@SergBobrovsky That is an optional change but can be automated via tools like https://github.com/asottile/pyupgrade |
remove
|
Also automated by pyupgrade. Give it a try to see the changes that it would make. |
Hey @defnull what's the status on this work? I'm happy to contribute but I saw your comment elsewhere stating you'd prefer this be done in smaller pieces? |
@@ -7,7 +7,7 @@ jobs: | |||
strategy: | |||
max-parallel: 5 | |||
matrix: | |||
python-version: [2.7, 3.5, 3.6, 3.7, 3.8] | |||
python-version: [3.5, 3.6, 3.7, 3.8] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at this point, according to https://endoflife.date/python, 3.5 and 3.6 can be dropped too, though we may want to drop that later on
This is the integration branch for python 2 removal. Please submit pull requests against this branch and discuss the entire process here.