Fix 602 unicode path encoding when mounting application. #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coding fails. If second conversion fails return original 400 error.
blakev
changed the title
|
Please merge this into master :( |
mgedmin
reviewed
Sep 13, 2018
| return HTTPError(400, 'Invalid path string. Expected UTF-8') | ||
| except UnicodeError: | ||
| try: # BUG 602 encoding path to latin1 may contain char not in utf8 | ||
| environ['PATH_INFO'] = urlunquote(path) |
There was a problem hiding this comment.
This does not seem safe to me. Repeated UTF-8 decoding might succeed (by accident), mangling actual data.
Besides, the WSGI spec requires environ['PATH_INFO'] to be raw bytes from the HTTP request, decoded as Latin-1. If you mount a WSGI app, bottle should convert it back before passing it to the mounted app.
IOW I think it would be better to fix this in mount().
|
removed this merge from bottle is an error. I still get this bug from Bottle v0.12.19 in 2022.02. although it was not so perfect but solve this bug! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #602