Fix wsgi.input lookup and demonstrate unit tests that need a request body #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Committed a version check fix for the unit test module. |
|
Closing. Resubmitting from a feature branch as-per the developer guidelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue #727 . I've fixed the runtime error by first creating a failing test which also demonstrates (for users of bottle.py) how to unit test a route function that uses a body. I couldn't personally see this anywhere on the web or in bottle.py's documentation.
Hopefully this is useful and to conventions/tastes of the project. I will happily provide a short documentation paragraph for the docs on bottlepy.org but have yet to work out how to do so.