Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SDK's Go toolchain #21

Merged
merged 4 commits into from
Apr 6, 2020
Merged

Use SDK's Go toolchain #21

merged 4 commits into from
Apr 6, 2020

Conversation

jahkeup
Copy link
Member

@jahkeup jahkeup commented Mar 2, 2020

Issue number:

#19

Description of changes:

This uses the bottlerocket/sdk-x86_64 container image to build the update operator's binaries.

Testing done:

Built a container image and ran unit tests.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@jahkeup jahkeup self-assigned this Mar 2, 2020
@jahkeup jahkeup changed the title Use sdk go Use SDK's Go toolchain Mar 2, 2020
@jahkeup jahkeup force-pushed the licenses-licenses branch 2 times, most recently from d06d8e0 to d5fb7fd Compare March 2, 2020 19:59
Makefile Outdated Show resolved Hide resolved
@jahkeup
Copy link
Member Author

jahkeup commented Apr 6, 2020

I want to bump this to use the latest SDK image before we merge this in (it got bumped to 0.10.1 in the OS repo).

@jahkeup jahkeup changed the base branch from licenses-licenses to develop April 6, 2020 16:50
@jahkeup
Copy link
Member Author

jahkeup commented Apr 6, 2020

Bumped to v0.10.1 and rebased. It builds 🍿

Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☺️

@jahkeup jahkeup merged commit ba899f0 into develop Apr 6, 2020
@jahkeup jahkeup deleted the use-sdk-go branch April 6, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants