-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update netdog to a more recent version of the toml library #3422
Comments
I wasn't immediately sure why order mattered, so documenting what I found in the code:
|
On a brief look I couldn't find the |
I think that is fine. I think if unit tests are passing for all variants the we should be good. Net.toml is well tested and also the code has been worked on a fair amount since I opened this issue. If the tests are passing now then it would seem the behavior is fine.
I think it is because we have a weird lint that makes us feel like using two versions of a library is a bad thing. I'm not a fan of the lint (in cargo-deny). |
I may be misunderstanding you, but I'm not sure this would be the reason--there's already two different versions of the crate in use. |
Currently we do conditional compilation for |
The build bot should run all unit tests on PR submission: It runs across all variants, and the build does include a Personally, I think the "first interface is primary unless explicitly specified" is a bit of a misfeature, but one we're stuck with. At least the requirement for ordering is documented in the code (see first comment). |
Closed by #3830 |
Netdog cannot be easily upgraded to newer versions of the
toml
library because the featureperserve_order
no longer exists in newer versions oftoml
. When I tried removing the cargo feature and updating it to0.7
, a few tests failed.The text was updated successfully, but these errors were encountered: