Update go and rust dependencies #3830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmt-lab
force-pushed
the
jmt/1.19.3/dependency
branch
3 times, most recently
from
8ccaad6
to
b27e4b7
Compare
|
hyper proxy fix, this should hopefully get us going |
jmt-lab
force-pushed
the
jmt/1.19.3/dependency
branch
2 times, most recently
from
636143d
to
393c0fa
Compare
jmt-lab
force-pushed
the
jmt/1.19.3/dependency
branch
from
393c0fa
to
7a8ed39
Compare
|
Unit tests passed, good to go |
jmt-lab
force-pushed
the
jmt/1.19.3/dependency
branch
9 times, most recently
from
15c3ea0
to
f3cba92
Compare
yeazelm
reviewed
Mar 19, 2024
jmt-lab
force-pushed
the
jmt/1.19.3/dependency
branch
2 times, most recently
from
1b3d953
to
2e5debf
Compare
|
Test Report for migration testing and k8s conformance: |
jpculp
approved these changes
Mar 20, 2024
webern
approved these changes
Mar 21, 2024
| @@ -59,7 +60,7 @@ impl Terminal { | |||
|
|
|||
| // Get the current settings of the user's terminal so we can restore them later. | |||
| let current_termios = | |||
| tcgetattr(STDOUT_FILENO).context(error::TermAttrSnafu { op: "get" })?; | |||
| tcgetattr(io::stdout()).context(error::TermAttrSnafu { op: "get" })?; | |||
There was a problem hiding this comment.
note: test enter-admin-container
| async fn sdk_imds_client() -> Result<imds::Client> { | ||
| fn sdk_imds_client() -> imds::Client { |
There was a problem hiding this comment.
Woah, wait a minute. The IMDS client went from async to blocking?
| @@ -45,7 +46,7 @@ pub(crate) fn fetch_proxy_env() -> (Option<String>, Option<String>) { | |||
| pub(crate) fn setup_http_client( | |||
| https_proxy: String, | |||
| no_proxy: Option<String>, | |||
| ) -> Result<impl Into<aws_smithy_client::http_connector::HttpConnector>> { | |||
| ) -> Result<ProxyConnector<HttpsConnector<HttpConnector>>> { | |||
sources/deny.toml
Outdated
| { name = "base64", version = "=0.13" }, | ||
| # AWS SDK for rust uses an older version of fastrand | ||
| { name = "fastrand", version = "=1.9" }, | ||
| # sdk still uses 0.7.5 but everything in this repo now uses 0.8.2 |
There was a problem hiding this comment.
"sdk" is ambiguous. Use "settings sdk" everywhere to be more clear.
Suggested change
| # sdk still uses 0.7.5 but everything in this repo now uses 0.8.2 | |
| # settings sdk still uses 0.7.5 but everything in this repo now uses 0.8.2 |
jmt-lab
force-pushed
the
jmt/1.19.3/dependency
branch
from
2e5debf
to
02159dd
Compare
|
Updated per matt's comment. Proxy tested and passes
|
jmt-lab
force-pushed
the
jmt/1.19.3/dependency
branch
from
02159dd
to
3a0d6d3
Compare
jpculp
approved these changes
Mar 21, 2024
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Testing done:
testsys run will be kicked off in the morning
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.