-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install migrator and migration helpers #125
Conversation
This mostly addresses #90, with some points worth discussing:
So we'd also need to decide on a list of migration names per version, unless we unconditionally install every migration for a given version. |
Assuming we want migrations for version X, we'd want every migration under X. The names are just there for the developer of the migration to briefly explain their purpose. Anything tagged to a specific version is expected to be required for that version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! What do you think is left before merging? I could probably help test the branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Install the migrator tool and individual migration helpers into the image. This defines a 'migration' package that must be required-by the release package, and extends the cargo_install macro to optionally specify the root directory. Migration versions are specified in a macro which is used in the %install step to install all migrations found for each version. Signed-off-by: Samuel Mendoza-Jonas <samjonas@amazon.com>
Issue #, if available:
#90
Description of changes:
Install the migrator tool and individual migration helpers into the
image. This defines a 'migration' package that must be required-by the
release package, and extends the cargo_install macro to optionally
specify the root directory.
Migration versions are only specified in the install for-loop at the
moment, but otherwise are automatically handled by populating a
migration-binaries file to use with
%files -f
Signed-off-by: Samuel Mendoza-Jonas samjonas@amazon.com
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.