update_metadata: remove tough dependency #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjkirch
approved these changes
Mar 13, 2021
More consistent error variant naming in Migrator. |
Oops typo |
Removes the update_metadata dependency on tough. This removes a lot of heavyweight dependencies from update_metadata, including tokio, reqwest, hyper, and tough. update_metadata is used cross-workspace by pubsys, so removing tough from update_metadata keeps the cross-workspace dependency duplication to a minimum.
Add backtrace field in Updog error variants to stay consistent with the existing pattern. |
tjkirch
approved these changes
Mar 15, 2021
etungsten
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#1377
Description of changes:
Testing done:
Ran pods, did an upgrade.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.