kernel: disable CMDLINE_EXTEND #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used to extend the kernel command line with default options. Bottlerocket has fairly specific needs for the kernel command line, so we want to use what we set in grub (via rpm2img) and nothing else.
bcressey
approved these changes
Apr 9, 2021
jpculp
approved these changes
Apr 9, 2021
arnaldo2792
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In particular, the upstream aarch64 kernel config has
CONFIG_CMDLINE="console=ttyAMA0", which isn't compatible with EC2 arm64 instances the way we use them - you see kernel startup messages, but nothing from systemd/journald. This only started to impact us with the kernel update in #1460 which enabled CMDLINE_EXTEND.The x86 kernel config has no
CONFIG_CMDLINEand so isn't impacted.Testing done:
With this, on an aarch64 instance, I now see systemd/journald output in the EC2 console. Also confirmed that an x86 instance is unimpacted, and that basic functionality and health were still OK.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.