Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: cargo update #1574

Merged
merged 1 commit into from
May 14, 2021
Merged

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented May 14, 2021

Description of changes:

tools: cargo update

indicatif has to be updated in pubsys because it passes a progress bar to
coldsnap, so the versions have to match.

This is mainly to get awslabs/coldsnap#56 which should improve reliability of CI builds for Bottlerocket.

Testing done:

I confirmed that cargo make ami, cargo make repo, cargo make ssm, cargo make check-repo-expirations, cargo make validate-repo, and cargo make refresh-repo still work OK.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

indicatif has to be updated in pubsys because it passes a progress bar to
coldsnap, so the versions have to match.
Copy link
Contributor

@etungsten etungsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please do a quick test of cargo make check-repo-expirations, cargo make validate-repo, and maybe cargo make refresh-repo?

I'm wondering if it's worth adding all those cargo make tasks that depend on pubsys to github actions workflow. It would be great if it can conditionally run it depending on which directory has changes (./tools in this case).

@tjkirch
Copy link
Contributor Author

tjkirch commented May 14, 2021

Can you also please do a quick test of cargo make check-repo-expirations, cargo make validate-repo, and maybe cargo make refresh-repo?

@etungsten Still worked! Made #1575 so I could test them locally.

@tjkirch tjkirch merged commit 4f797f0 into bottlerocket-os:develop May 14, 2021
@tjkirch tjkirch deleted the cargo-update-tools branch May 14, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants