Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use runtime.slice and system.slice cgroup settings in k8s variants #1684

Merged
merged 6 commits into from Aug 9, 2021
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/containerd/containerd.service
Expand Up @@ -5,6 +5,7 @@ After=network-online.target configured.target
Wants=network-online.target configured.target

[Service]
Slice=runtime.slice
EnvironmentFile=/etc/network/proxy.env
ExecStart=/usr/bin/containerd
Type=notify
Expand Down
2 changes: 2 additions & 0 deletions packages/kubernetes-1.17/kubelet-config
Expand Up @@ -68,11 +68,13 @@ kubeReserved:
{{~/if}}
{{~/if}}
ephemeral-storage: "{{default "1Gi" settings.kubernetes.kube-reserved.ephemeral-storage}}"
kubeReservedCgroup: "/runtime"
cyrus-mc marked this conversation as resolved.
Show resolved Hide resolved
{{~#if settings.kubernetes.system-reserved}}
systemReserved:
{{~#each settings.kubernetes.system-reserved}}
{{@key}}: "{{this}}"
{{~/each}}
systemReservedCgroup: "/system"
{{~/if}}
cpuManagerPolicy: {{default "none" settings.kubernetes.cpu-manager-policy}}
{{~#if settings.kubernetes.cpu-manager-reconcile-period}}
Expand Down
1 change: 1 addition & 0 deletions packages/kubernetes-1.17/kubelet.service
Expand Up @@ -6,6 +6,7 @@ Wants=configured.target
BindsTo=containerd.service

[Service]
Slice=runtime.slice
Type=notify
EnvironmentFile=/etc/network/proxy.env
EnvironmentFile=/etc/kubernetes/kubelet/env
Expand Down
2 changes: 2 additions & 0 deletions packages/kubernetes-1.18/kubelet-config
Expand Up @@ -68,11 +68,13 @@ kubeReserved:
{{~/if}}
{{~/if}}
ephemeral-storage: "{{default "1Gi" settings.kubernetes.kube-reserved.ephemeral-storage}}"
kubeReservedCgroup: "/runtime"
{{~#if settings.kubernetes.system-reserved}}
systemReserved:
{{~#each settings.kubernetes.system-reserved}}
{{@key}}: "{{this}}"
{{~/each}}
systemReservedCgroup: "/system"
{{~/if}}
cpuManagerPolicy: {{default "none" settings.kubernetes.cpu-manager-policy}}
{{~#if settings.kubernetes.cpu-manager-reconcile-period}}
Expand Down
1 change: 1 addition & 0 deletions packages/kubernetes-1.18/kubelet.service
Expand Up @@ -6,6 +6,7 @@ Wants=configured.target
BindsTo=containerd.service

[Service]
Slice=runtime.slice
Type=notify
EnvironmentFile=/etc/network/proxy.env
EnvironmentFile=/etc/kubernetes/kubelet/env
Expand Down
2 changes: 2 additions & 0 deletions packages/kubernetes-1.19/kubelet-config
Expand Up @@ -68,11 +68,13 @@ kubeReserved:
{{~/if}}
{{~/if}}
ephemeral-storage: "{{default "1Gi" settings.kubernetes.kube-reserved.ephemeral-storage}}"
kubeReservedCgroup: "/runtime"
{{~#if settings.kubernetes.system-reserved}}
systemReserved:
{{~#each settings.kubernetes.system-reserved}}
{{@key}}: "{{this}}"
{{~/each}}
systemReservedCgroup: "/system"
{{~/if}}
cpuManagerPolicy: {{default "none" settings.kubernetes.cpu-manager-policy}}
{{~#if settings.kubernetes.cpu-manager-reconcile-period}}
Expand Down
1 change: 1 addition & 0 deletions packages/kubernetes-1.19/kubelet.service
Expand Up @@ -6,6 +6,7 @@ Wants=configured.target
BindsTo=containerd.service

[Service]
Slice=runtime.slice
Type=notify
EnvironmentFile=/etc/network/proxy.env
EnvironmentFile=/etc/kubernetes/kubelet/env
Expand Down
2 changes: 2 additions & 0 deletions packages/kubernetes-1.20/kubelet-config
Expand Up @@ -68,11 +68,13 @@ kubeReserved:
{{~/if}}
{{~/if}}
ephemeral-storage: "{{default "1Gi" settings.kubernetes.kube-reserved.ephemeral-storage}}"
kubeReservedCgroup: "/runtime"
{{~#if settings.kubernetes.system-reserved}}
systemReserved:
{{~#each settings.kubernetes.system-reserved}}
{{@key}}: "{{this}}"
{{~/each}}
systemReservedCgroup: "/system"
{{~/if}}
cpuManagerPolicy: {{default "none" settings.kubernetes.cpu-manager-policy}}
{{~#if settings.kubernetes.cpu-manager-reconcile-period}}
Expand Down
1 change: 1 addition & 0 deletions packages/kubernetes-1.20/kubelet.service
Expand Up @@ -6,6 +6,7 @@ Wants=configured.target
BindsTo=containerd.service

[Service]
Slice=runtime.slice
Type=notify
EnvironmentFile=/etc/network/proxy.env
EnvironmentFile=/etc/kubernetes/kubelet/env
Expand Down
2 changes: 2 additions & 0 deletions packages/kubernetes-1.21/kubelet-config
Expand Up @@ -68,11 +68,13 @@ kubeReserved:
{{~/if}}
{{~/if}}
ephemeral-storage: "{{default "1Gi" settings.kubernetes.kube-reserved.ephemeral-storage}}"
kubeReservedCgroup: "/runtime"
{{~#if settings.kubernetes.system-reserved}}
systemReserved:
{{~#each settings.kubernetes.system-reserved}}
{{@key}}: "{{this}}"
{{~/each}}
systemReservedCgroup: "/system"
{{~/if}}
cpuManagerPolicy: {{default "none" settings.kubernetes.cpu-manager-policy}}
{{~#if settings.kubernetes.cpu-manager-reconcile-period}}
Expand Down
1 change: 1 addition & 0 deletions packages/kubernetes-1.21/kubelet.service
Expand Up @@ -6,6 +6,7 @@ Wants=configured.target
BindsTo=containerd.service

[Service]
Slice=runtime.slice
Type=notify
EnvironmentFile=/etc/network/proxy.env
EnvironmentFile=/etc/kubernetes/kubelet/env
Expand Down
2 changes: 2 additions & 0 deletions packages/release/release-tmpfiles.conf
Expand Up @@ -2,4 +2,6 @@ C /etc/hosts - - - -
C /etc/nsswitch.conf - - - -
C /etc/wicked/ifconfig/eth0.xml - - - -
d /var/log/kdump 0700 root root -
d /sys/fs/cgroup/cpuset/runtime.slice 0755 root root -
cyrus-mc marked this conversation as resolved.
Show resolved Hide resolved
d /sys/fs/cgroup/hugetlb/runtime.slice 0755 root root -
T /var/log/kdump - - - - security.selinux=system_u:object_r:secret_t:s0
6 changes: 5 additions & 1 deletion packages/release/release.spec
Expand Up @@ -49,6 +49,9 @@ Source1060: capture-kernel-dump.service
Source1061: disable-kexec-load.service
Source1062: load-crash-kernel.service

# systemd cgroups/slices
Source1080: runtime.slice

BuildArch: noarch
Requires: %{_cross_os}acpid
Requires: %{_cross_os}audit
Expand Down Expand Up @@ -111,7 +114,7 @@ install -d %{buildroot}%{_cross_unitdir}
install -p -m 0644 \
%{S:1001} %{S:1002} %{S:1003} %{S:1004} %{S:1005} \
%{S:1006} %{S:1007} %{S:1008} %{S:1009} %{S:1010} %{S:1011} \
%{S:1015} %{S:1040} %{S:1041} %{S:1060} %{S:1061} %{S:1062} \
%{S:1015} %{S:1040} %{S:1041} %{S:1060} %{S:1061} %{S:1062} %{S:1080} \
%{buildroot}%{_cross_unitdir}

LOWERPATH=$(systemd-escape --path %{_cross_sharedstatedir}/kernel-devel/lower)
Expand Down Expand Up @@ -166,6 +169,7 @@ ln -s %{_cross_unitdir}/preconfigured.target %{buildroot}%{_cross_unitdir}/defau
%{_cross_unitdir}/*-kernels.mount
%{_cross_unitdir}/*-licenses.mount
%{_cross_unitdir}/var-lib-bottlerocket.mount
%{_cross_unitdir}/runtime.slice
%{_cross_unitdir}/set-hostname.service
%dir %{_cross_templatedir}
%{_cross_templatedir}/motd
Expand Down
4 changes: 4 additions & 0 deletions packages/release/runtime.slice
@@ -0,0 +1,4 @@
[Unit]
Description=Kubernetes and container runtime slice
Documentation=man:systemd.special(7)
Before=slices.target