Add region flag to aws-iam-authenticator command #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilboMo
force-pushed
the
region-flag
branch
from
6095c0b
to
dc625a4
Compare
bcressey
reviewed
Sep 29, 2021
|
LGTM once @bcressey 's suggestion is fixed. |
WilboMo
force-pushed
the
region-flag
branch
from
dc625a4
to
32461e1
Compare
webern
approved these changes
Sep 29, 2021
Adds `--region` to the aws-iam-authenticator command to reflect upstream changes.
WilboMo
force-pushed
the
region-flag
branch
from
32461e1
to
eab6582
Compare
bcressey
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Adds
--regionflag toaws-iam-authenticatorcommand to reflect AL2 EKS changes to support additional regions.Testing done:
Created EKS Clusters for the following variants:
Confirmed updates to
kubelet-kubeconfigallowed Bottlerocket nodes for each cluster to join successfully and deploy pods.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.