docs: Mention static pods in the security guidance around api access #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etungsten
approved these changes
Oct 1, 2021
bcressey
reviewed
Oct 1, 2021
SECURITY_GUIDANCE.md
Outdated
| @@ -71,6 +71,7 @@ It is labeled `api_socket_t`, so only processes with privileged SELinux labels c | |||
| Write access to this socket will grant full control over system configuration. | |||
| This includes the ability to define an arbitrary source for a host container, and to run that container with "superpowers" that bypass other restrictions. | |||
| These "superpowers" are described [below](#limit-use-of-host-containers). | |||
| It also includes the ability to define and run static pods, which are managed directly by `kubelet` and are not subject to admission controllers that enforce security policies for the Kubernetes cluster. | |||
There was a problem hiding this comment.
Suggested change
| It also includes the ability to define and run static pods, which are managed directly by `kubelet` and are not subject to admission controllers that enforce security policies for the Kubernetes cluster. | |
| For Kubernetes variants, it also includes the ability to define and run static pods. These are managed directly by `kubelet` and are not subject to admission controllers that enforce security policies for the cluster. |
We recommend against providing access to the API socket from containers because of the effects it can have on system configuration and security. This change specifically calls out the ability to define static pods as an action that could be taken with API access, and the effects of doing so.
zmrow
force-pushed
the
static_pods_guidance
branch
from
180b35c
to
fce75f8
Compare
|
^ Fixed @bcressey 's suggestions |
bcressey
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.