Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to SDK 0.23.0 #1779

Merged
merged 2 commits into from Oct 27, 2021
Merged

update to SDK 0.23.0 #1779

merged 2 commits into from Oct 27, 2021

Conversation

bcressey
Copy link
Contributor

Issue number:
N/A

Description of changes:
Uses the SDK with changes from bottlerocket-os/bottlerocket-sdk#60. Notably, this includes newer versions of Rust, Go, and cargo-deny.

Testing done:
Confirmed that new cargo deny checks pass with no warnings.

Built aws-k8s-1.21 variants for x86_64 and aarch64; confirmed that a sonobuoy run passes with no issues.

Built aws-ecs-1 variant for x86_64 and verified that tasks ran OK.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo HACK

@tjkirch
Copy link
Contributor

tjkirch commented Oct 15, 2021

Should we use this PR to update the GitHub workflows to use Rust 1.55 to match SDK?

@tjkirch
Copy link
Contributor

tjkirch commented Oct 21, 2021

Rust 1.56 is out! 🎉 https://blog.rust-lang.org/2021/10/21/Rust-1.56.0.html

@bcressey
Copy link
Contributor Author

rebase with no changes

Signed-off-by: Ben Cressey <bcressey@amazon.com>
Path dependencies without a specified version will be treated as a
wildcard dependency and cause an error, so add the version to each.

Block multiple versions of crates, but skip the existing cases. The
goal is to prevent new instances from coming in unnoticed.

Signed-off-by: Ben Cressey <bcressey@amazon.com>
@bcressey
Copy link
Contributor Author

Fix new wildcard dependencies, and update to Rust 1.56.0 for the actions workflow.

@bcressey bcressey marked this pull request as ready for review October 27, 2021 18:51
@bcressey bcressey merged commit 97400c3 into bottlerocket-os:develop Oct 27, 2021
@bcressey bcressey deleted the sdk-bump branch October 27, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants