Add driverdog to link and load kernel modules at runtime #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etungsten
approved these changes
Dec 14, 2021
packages/release/Cargo.toml
Outdated
| ca-certificates = { path = "../ca-certificates" } | ||
| binutils = { path = "../binutils" } |
There was a problem hiding this comment.
super nit: should keep this sorted.
Suggested change
| ca-certificates = { path = "../ca-certificates" } | |
| binutils = { path = "../binutils" } | |
| binutils = { path = "../binutils" } | |
| ca-certificates = { path = "../ca-certificates" } |
bcressey
reviewed
Dec 16, 2021
| RefuseManualStart=true | ||
| RefuseManualStop=true | ||
| After=link-kernel-modules.service | ||
| Wants=link-kernel-modules.service |
There was a problem hiding this comment.
nit: could strengthen this dependency -
Suggested change
| Wants=link-kernel-modules.service | |
| Requires=link-kernel-modules.service |
sources/driverdog/src/main.rs
Outdated
Comment on lines
109
to
120
| // If the target module set was given, link the kernel modules in it | ||
| if let Some(target) = target { | ||
| let driver_config = modules_sets | ||
| .get(&target) | ||
| .context(error::MissingModuleSet { target })?; | ||
| link_modules(&driver_config, &kernel_version)? | ||
| } | ||
|
|
||
| // Link all the modules sets if no target module was given | ||
| for driver_config in modules_sets.values() { | ||
| link_modules(&driver_config, &kernel_version)?; | ||
| } |
There was a problem hiding this comment.
Looks like we always link all module sets, even if we pass the option for a specific set. The load modules function has the same issue.
There was a problem hiding this comment.
Good catch, missing else block? (Edit: Resolved)
webern
approved these changes
Dec 30, 2021
sources/driverdog/src/main.rs
Outdated
Comment on lines
109
to
120
| // If the target module set was given, link the kernel modules in it | ||
| if let Some(target) = target { | ||
| let driver_config = modules_sets | ||
| .get(&target) | ||
| .context(error::MissingModuleSet { target })?; | ||
| link_modules(&driver_config, &kernel_version)? | ||
| } | ||
|
|
||
| // Link all the modules sets if no target module was given | ||
| for driver_config in modules_sets.values() { | ||
| link_modules(&driver_config, &kernel_version)?; | ||
| } |
There was a problem hiding this comment.
Good catch, missing else block? (Edit: Resolved)
Binutils provides the ld linker, required to link proprietary kernel modules at runtime. Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
|
Forced push includes rebase to resolve conflicts |
driverdog is a tool to link kernel modules at runtime, given a
configuration. The configuration must be provided per driver vendor, and
it is created at runtime by the tmpfilesd daemon, using a file
from the %{_cross_factorydir} directory.
Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
arnaldo2792
force-pushed
the
driverdog
branch
from
67cd1e9
to
cf7b439
Compare
|
Forced push includes:
|
webern
approved these changes
Jan 11, 2022
bcressey
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N / A
Description of changes:
Related to #1799 , that PR is quite big. I'm taking some of the commits in that PR as their individual PR.
We can't ship kernel modules linked against GPL code (i. e. proprietary kernel modules), doing so violates the GPL license under which the kernel is released. Instead, Bottlerocket images with proprietary kernel modules will link and load the kernel modules at runtime using
driverdog.binutilsis built as part of thereleasepackage, but it isn't included in any variant. Instead, packages that depend on it will include it in their spec file, as follows:Testing done:
In the new variant created in #1799:
Shipped a drivers configuration file that looks as follows, along with required objects in the OS image:
Validated the kernel modules were linked and loaded:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.