Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap-containers/README.md #1959

Merged
merged 4 commits into from Feb 28, 2022

Conversation

effy-coding
Copy link
Contributor

VAR_DIR (undeclared) => HOST_VAR_DIR

Issue number:

Description of changes:

Testing done:

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

`VAR_DIR` (undeclared) => `HOST_VAR_DIR`
@effy-coding effy-coding changed the title Update README.md Update bootstrap-containers/README.md Feb 16, 2022
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!!

🫕

Copy link
Contributor

@etungsten etungsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md is generated from the crate's doc comments at the top of main.rs here:

HOST_VAR_DIR=/.bottlerocket/rootfs/var
# The directory that'll be created by this bootstrap container
MY_HOST_DIR=$VAR_DIR/lib/my_directory

The fix should go there as well. If you have cargo installed, you can regenerate the README by running cargo check to invoke the build.rs script.

@arnaldo2792
Copy link
Contributor

Thanks! LGTM provided the change suggested by @etungsten is addressed 👍

@effy-coding
Copy link
Contributor Author

@etungsten I changed comment of bottlerocket/sources/api/bootstrap-containers/src/main.rs Not README.md

Thanks

@arnaldo2792 @zmrow

@etungsten
Copy link
Contributor

I changed comment of bottlerocket/sources/api/bootstrap-containers/src/main.rs Not README.md

Hi @dangen-effy , the change would need to happen for both bottlerocket/sources/api/bootstrap-containers/src/main.rs and bottlerocket/sources/api/bootstrap-containers/README.md. Sorry for being unclear.

@effy-coding
Copy link
Contributor Author

@etungsten It was my mistake! Now i edited both.

Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@etungsten etungsten merged commit 6d32a54 into bottlerocket-os:develop Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants