documentation: explain data partition extension #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Mar 22, 2022
README.md
Outdated
Comment on lines
818
to
819
| Bottlerocket will increase the partition size to use all of `/dev/xcdb` on boot. | ||
| If you increase the size of that device, you can reboot Bottlerocket to extend the data partition. |
There was a problem hiding this comment.
It's not guaranteed that the device will be xvdb:
- on Nitro instance types, it will be
nvme1n1 - on variants using "unified", it could be
xvdaornvme0n1
However, I'm not sure there's a great way to introduce that level of detail here; we'd need to rewrite it a bit first to mention "split" vs "unified". It might help to just remove the specific device names.
|
^ describe data partition extension without referring to device names. |
|
^ remove a comma |
bcressey
approved these changes
Mar 22, 2022
etungsten
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #2012
Description of changes:
Adds a note in the documentation about how you can extend the data partition by rebooting and points to existing discussion about doing so without rebooting.
Testing done:
Testing was done during discussion #2011
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.