Restart container runtimes when certificates store changes #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webern
approved these changes
Apr 18, 2022
bcressey
requested changes
Apr 20, 2022
sources/models/src/aws-k8s-1.19/defaults.d/53-containerd-pki.toml
Outdated
Show resolved
Hide resolved
|
It'd be worth rebasing this to exercise more of the functionality after the |
arnaldo2792
force-pushed
the
fix-ca-certificates
branch
from
338cc9a
to
7941eda
Compare
|
(Rebase to pull down migrations directory for next release) |
arnaldo2792
force-pushed
the
fix-ca-certificates
branch
from
7941eda
to
2d56326
Compare
|
(Rebase to pull down latest changes in |
arnaldo2792
force-pushed
the
fix-ca-certificates
branch
from
2d56326
to
2512f09
Compare
|
Forced push includes migration and configuration files for newly added variants |
arnaldo2792
force-pushed
the
fix-ca-certificates
branch
from
2512f09
to
6a6ddf3
Compare
|
(Rebased to pull down fixes in aws-ecs-1-nvidia) |
arnaldo2792
force-pushed
the
fix-ca-certificates
branch
from
6a6ddf3
to
ed7a551
Compare
|
(Fix since I was using |
webern
approved these changes
Jun 3, 2022
|
|
||
| fn main() { | ||
| let variant = Variant::from_env().unwrap(); | ||
| variant.emit_cfgs(); |
etungsten
approved these changes
Jun 4, 2022
Comment on lines
9
to
10
| /// We updated the 'affected-services' list metadata for 'settings.network.hostname' to include the | ||
| /// hosts "service" on upgrade, and to remove it on downgrade. |
There was a problem hiding this comment.
This comment is not accurate.
arnaldo2792
force-pushed
the
fix-ca-certificates
branch
from
ed7a551
to
ae88e38
Compare
|
(Forced push to fix comment in migration) |
bcressey
approved these changes
Jun 6, 2022
…hanges The containerd and docker daemons cache the certificates store, so any updates to the store will be ignored by the daemons. With this, the daemons will be restarted whenever the certificates store is updated. Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
arnaldo2792
force-pushed
the
fix-ca-certificates
branch
from
ae88e38
to
4ac5ae7
Compare
|
(Forced push to fix merge conflicts with |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #2021
Description of changes:
Testing done:
In aws-ecs-1, aws-k8s-1.21:
ECS:
k8s:
I deployed a pod that used an image in my local registry, since k8s variants don't have docker. After I updated the certificates store (like in the ECS test), the image was successfully pulled:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.