Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new Kubelet setting podPidsLimit #2138

Merged
merged 2 commits into from May 19, 2022

Conversation

gthao313
Copy link
Member

@gthao313 gthao313 commented May 17, 2022

Issue number:
#2130

Description of changes:
Adds a new settings kubernetes.podPidsLimit

Testing done:

Effected side test

Setting podPidsLimit to a small number which would fail to create pod because it doesn't have room for system process and daemon process alive.
setting.kubernetes.pod-pids-limit = 1

...
May 17 03:06:17 ip-192-168-86-168.us-west-2.compute.internal kubelet[4151]: E0517 03:06:17.103675    4151 pod_workers.go:918] "Error syncing pod, skipping" err="failed to \"CreatePodSandbox\" for \"aws-node-xhdtk_kube-system(c711d7d6-6de3-48ed-984a-4afafe1ae6b1)\" with 

CreatePodSandboxError: \"Failed to create sandbox for pod \\\"aws-node-xhdtk_kube-system(c711d7d6-6de3-48ed-984a-4afafe1ae6b1)\\\": rpc error: code = Unknown desc = failed to create containerd task: failed to create shim: OCI runtime create failed: runc create failed: 

unable to start container process: can't get final child's PID from pipe: EOF: unknown\"" pod="kube-system/aws-node-xhdtk" podUID=c711d7d6-6de3-48ed-984a-4afafe1ae6b1
...

Migration test

Update to latest version

bash-5.1# updog check-update -a --json
[
  {
    "variant": "aws-k8s-1.22",
    "arch": "x86_64",
    "version": "1.8.0",
    "max_version": "1.8.0",
    }
  }
]
bash-5.1# updog update -i 1.8.0 -r -n
Starting update to 1.8.0

set podPidslimit

apiclient set -j '{"kubernetes": {"pod-pids-limit": 100}}'

cat var/lib/bottlerocket/datastore/current/live/settings/kubernetes/pod-pids-limit
100

signpost rollback-to-inactive

cat: var/lib/bottlerocket/datastore/current/live/settings/kubernetes/pod-pids-limit: No such file or directory

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@gthao313 gthao313 marked this pull request as ready for review May 17, 2022 18:20
@gthao313 gthao313 merged commit 72c0321 into bottlerocket-os:develop May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants