Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash: update to 5.1.16 #2145

Merged

Conversation

markusboehme
Copy link
Member

Issue number:

#1613

Description of changes:

This updates the bash of the host, included in the -dev variants only, to version 5.1.16. The bash used now matches the version in the admin container used by sheltie.

Testing done:

  • I built several variants multiple times and for both aarch64 and x86_64 (cross-compiled). I did not encounter the issue in Update bash to 5.1 #1613.
  • Booted the metal-dev variant in QEMU and verified the bash version being used:
bash-5.1# echo ${BASH_VERSION}
5.1.16(1)-release
bash-5.1# bash --version
GNU bash, version 5.1.16(1)-release (aarch64-bottlerocket-linux-gnu)
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@bcressey bcressey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The commit is showing "fedora Cloud User committed 3 hours ago" so maybe amend the committer info.

Signed-off-by: Markus Boehme <markubo@amazon.com>
@markusboehme
Copy link
Member Author

The commit is showing "fedora Cloud User committed 3 hours ago" so maybe amend the committer info.

Indeed, an artifact from a freshly setup developer box. Thanks to you and @jpculp for noticing!

I updated the PR with proper author information.

@markusboehme markusboehme merged commit 915362b into bottlerocket-os:develop May 20, 2022
@markusboehme markusboehme mentioned this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants