Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update tokio #2180

Merged
merged 1 commit into from Jun 6, 2022
Merged

tools: update tokio #2180

merged 1 commit into from Jun 6, 2022

Conversation

webern
Copy link
Member

@webern webern commented Jun 6, 2022

We do not need to pin tokio to an LTS version in the tools workspace
since we are not publishing these tools. We just need to make sure
they are working and keep tokio up-to-date.

Issue number:

Closes #2153

Description of changes:

Unpin tokio and use the latest version in the tools workspace.

Testing done:

Working on it now:

  • cargo make ami
  • cargo make repo

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

We do not need to pin tokio to an LTS version in the tools workspace
since we are not publishing these tools. We just need to make sure
they are working and keep tokio up-to-date.
@webern webern requested review from cbgbt and zmrow June 6, 2022 21:02
Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending testing 🚀

@webern
Copy link
Member Author

webern commented Jun 6, 2022

Cargo make ami and cago make repo are working.

@webern webern requested a review from etungsten June 6, 2022 21:19
@webern webern merged commit bb992c3 into bottlerocket-os:develop Jun 6, 2022
@webern webern deleted the tokio branch June 6, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tools: unpin or update tokio
4 participants