tools: add diff-kernel-config to identify kernel config changes #2368
Conversation
markusboehme
force-pushed
the
diff-kernel-config
branch
from
96c4749
to
db09e23
Compare
Users wouldn't be interested in this unless they spin their own variant and modify the kernel packages. I wouldn't expect it in either the top-level |
| rpm2cpio "${latest_archive_rpms[0]}" \ | ||
| | cpio --quiet --extract --to-stdout \ | ||
| | tar --xz --extract --to-stdout kernel-devel/scripts/diffconfig >"${diffconfig}" |
There was a problem hiding this comment.
There is a lot to love in this script but this may be my favorite part.
| # Generate combined report of changes | ||
| head -v -n 999999 "${output_dir}"/*-diff >"${output_dir}"/diff-report | ||
| echo "A full report has been placed in '${output_dir}/diff-report'" |
There was a problem hiding this comment.
If the report itself is the only reason to keep the directory around, it might be a nicer interface to use a temporary directory for the output, and just copy the report out as a permanent, gitignore'd file at the end.
That would trade off the need to keep track of output directories that don't yet exist with the need to occasionally prune older report files.
There was a problem hiding this comment.
Personally, I haven't really made up my mind yet on this matter. I've found use for both the combined report and the individual files. Let's see how folks will use it in the next PRs and decide one way or the other? I agree on simplifying the interface should it turn out the combined report is all that's getting used.
With multiple kernel versions being supported for two architectures in cloud and metal flavors it can be tedious and error-prone to get the full picture on the effects changes have on the resulting kernel configurations. The new diff-kernel-config tool helps automate this task. diff-kernel-config compares kernel configurations before and after a series of commits to the Bottlerocket repository. For this, it runs several full kernel builds that cover all possible combinations of kernel version, architecture, and cloud/metal flavor that could be shipped in any of the official variants. Combinations not used in any variant are skipped. diff-kernel-config produces kernel config diffs broken down by combination in its output directory, alongside a comprehensive report of all changes and a summary that can aid the code review process. Signed-off-by: Markus Boehme <markubo@amazon.com>
The diff-kernel-config tool may not be easily discoverable in the tools/ directory of the repository. Create minimal readme files in the kernel packages that point out its existence. The tool's usage information will answer any questions about how to produce the desired config change report. Signed-off-by: Markus Boehme <markubo@amazon.com>
markusboehme
force-pushed
the
diff-kernel-config
branch
from
db09e23
to
437ed20
Compare
|
The force push fixed leaking a temporary file and now comes with readme files in the kernel packages that point towards this script. |
Issue number: n/a
Description of changes:
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.