Migrations: migrate to admin container v0.9.2 #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpculp
force-pushed
the
admin-container-v0.9.2
branch
from
16874c6
to
ca4e7c7
Compare
|
Added a comma to hopefully avoid folks needing to rebase after. |
arnaldo2792
approved these changes
Oct 5, 2022
| @@ -4,7 +4,7 @@ superpowered = true | |||
|
|
|||
| [metadata.settings.host-containers.admin.source] | |||
| setting-generator = "schnauzer settings.host-containers.admin.source" | |||
| template = "{{ ecr-prefix settings.aws.region }}/bottlerocket-admin:v0.9.0" | |||
| template = "{{ ecr-prefix settings.aws.region }}/bottlerocket-admin:v0.9.2" | |||
There was a problem hiding this comment.
Nit: Probably a note in the commit (and description) about why we updated from 0.9.0 to 0.9.2 could help :D!
There was a problem hiding this comment.
I think that would get rather verbose. In general we should just treat this as a typical dependency bump and I suspect we're going to update our host containers more regularly going forward.
There was a problem hiding this comment.
Added Container changes to the description though. 🚀
gthao313
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update and migrate from admin container v0.9.0 to v0.9.2.
Container changes:
Remove /etc/config/selinux from image.
Testing done:
Tested in #2472, thanks @ecpullen!
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.