Add ShellCheck to check-lints (for tools)
#2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmcginnis
reviewed
Oct 28, 2022
bcressey
reviewed
Oct 28, 2022
| @@ -1,4 +1,5 @@ | |||
| #!/usr/bin/env bash | |||
| # shellcheck disable=SC2054 # Arrays are formatted for passing args to other tools | |||
There was a problem hiding this comment.
That shellcheck linter probably assumes the script is doing something dumb while assembling the QEMU invocation, where QEMU just needs commas in individual arguments. We could also quote those, but I think disabling the warning is the better choice for readability. 👍
|
|
Fixed a typo in one of the commit messages. |
markusboehme
approved these changes
Oct 28, 2022
stmcginnis
approved these changes
Oct 28, 2022
bcressey
approved these changes
Nov 2, 2022
This commit checks the bash scripts under tools during the `check-lints` task. For more targeted linting, `check-lints` was also split into `check-clippy` and `check-shell` which can be called individually.
|
etungsten
approved these changes
Nov 3, 2022
|
I rebased locally and ran |
bcressey
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
During the
check-lintsstage of the build, ShellCheck will analyze any bash scripts under thetoolsdirectory and raise an error for any findings with a severity ofwarningor above.For more targeted linting,
check-lintswas also split intocheck-clippyandcheck-shellwhich can be called individually.Also addressed several warnings to avoid breaking the build.
Testing done:
Ran with and without the
tools: fix ShellCheck warningscommit.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.