start-local-vm: rework image selection to use latest symlink #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `start-local-vm` hasn't been using the `latest` symlink to find the set of images to run with yet. That was needlessly complicated and actually broke with semi-recent changes to buildsys. Drop the code to clean up old extracted images. All extracted images now reside in the version-specific directories and can be removed with the other image build artifacts. Signed-off-by: Markus Boehme <markubo@amazon.com>
bcressey
approved these changes
Jan 4, 2023
webern
approved these changes
Jan 4, 2023
jpculp
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: n/a
Description of changes: The
start-local-vmhasn't been using thelatestsymlink to find the set of images to run with yet. That was needlessly complicated and actually broke with semi-recent changes to buildsys. Fix this by using thelatestsymlink and reworking the image selection code.Testing done: Launched local VMs with unified and split images, with and without
--force-extract.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.