fix clippy warnings for sources #2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adopt the fixes suggested by clippy in most cases. Disable pedantic warnings for the update metadata crate after fixing several. The intent seems to have been to hold the updater code to an especially high bar, but in practice it creates a higher maintenance burden when updating Rust, and requires changes in mission-critical code for merely stylistic reasons. Signed-off-by: Ben Cressey <bcressey@amazon.com>
Apply snafu annotations to box the error types most often flagged by the `clippy::result_large_err` lint, which complains whenever the Err part of a Result is greater than or equal to 128 bytes. This is most common for errors with several String fields, since each String occupies 24 bytes. That includes: * apiclient::Error * datastore::Error * tough:error::Error * handlebars::RenderError Also box a few larger types, like `semver::Version`, and use a Vec instead of an array for `PartitionSet`. Signed-off-by: Ben Cressey <bcressey@amazon.com>
Signed-off-by: Ben Cressey <bcressey@amazon.com>
stmcginnis
approved these changes
Jan 23, 2023
etungsten
approved these changes
Jan 23, 2023
webern
approved these changes
Jan 23, 2023
yeazelm
approved these changes
Jan 23, 2023
cbgbt
approved these changes
Jan 23, 2023
.../api/migration/migrations/v1.12.0/add-k8s-autoscaling-warm-pool-setting-metadata/src/main.rs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #1776 (finally)
Description of changes:
Fix all clippy warnings for the
sourcestree, and add coverage to the CI lint checks.Testing done:
cargo make check-lintspasses for three platforms:aws-k8s-1.24vmware-k8s-1.24metal-k8s-1.24Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.