prairiedog: allow '=' in bootconfig values #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'=' is allowed in values, so constrain the split accordingly. This fixes inputs like a `dm-mod.create` parameter that refers to the target block device with the `PARTUUID=.../PARTNROFF=#` syntax. Signed-off-by: Ben Cressey <bcressey@amazon.com>
etungsten
approved these changes
Feb 15, 2023
arnaldo2792
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
'=' is allowed in values, so constrain the split accordingly.
This fixes inputs like a
dm-mod.createparameter that refers to the target block device with thePARTUUID=.../PARTNROFF=#syntax.Testing done:
I found this while trying to use a corrupted
dm-mod.createparameter insettings.boot, which caused a boot failure whenprairiedogattempted to parse/proc/bootconfig.I've confirmed that this fix solves that problem and that the new unit test passes.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.