Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s: update eni-max-pods mapping for latest #2818

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

stmcginnis
Copy link
Contributor

Issue number:

Closes #2817

Description of changes:

This pulls in the new instance types to the eni-max-pods mapping file. It adds the max pod values for a new set of published instance types.

Generated content by using the update script.

Testing done:

Built aws-k8s-1.23 image and deployed. Checked settings to make sure the included changes are reflected:

# apiclient get settings.kubernetes.max-pods
{
  "settings": {
    "kubernetes": {
      "max-pods": 58
    }
  }
}

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@bcressey bcressey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently os.spec says this file comes from eni-max-pods.txt, so it might be good to document the new procedure there.

This pulls in the new instance types to the eni-max-pods mapping file.
It adds the max pod values for a new set of published instance types.

Also updates the comment in the spec file to indicate how this file and
its data is generated.

Signed-off-by: Sean McGinnis <stmcg@amazon.com>
@stmcginnis stmcginnis merged commit 4958085 into bottlerocket-os:develop Mar 2, 2023
@stmcginnis stmcginnis deleted the update-eni-max branch March 2, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New instance types for eni-max-pods
3 participants