ecs-gpu-init: upgrades Nvidia Go library #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John McBride <jpmmcb@amazon.com>
etungsten
approved these changes
Feb 24, 2023
stmcginnis
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Nice! I plan on doing more testing for some of the other package updates. But this doesn't need to wait for that. I have high confidence this is fine, and if we do find something we can always revert. So actually easier to get this in and combine some testing effort.
|
Sounds good - I'll push this in! Thanks Sean!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related to #2761
Description of changes:
Upgrades the Nvidia Go library to the latest tag
Testing done:
Built a custom aws-ecs-1-nvidia AMI and deployed it to a p2.xlarge machine (1 GPU)
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.