Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages: Add ethtool to release #2829

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Conversation

yeazelm
Copy link
Contributor

@yeazelm yeazelm commented Feb 24, 2023

Issue number:

Closes # 2794

Description of changes:
This adds ethtool to all variants.

Testing done:
Validated it works on a k8s variant in AWS:

[root@admin]# sudo sheltie
bash-5.1# ethtool eth0
Settings for eth0:
        Current message level: 0x000000f3 (243)
                               drv probe ifdown ifup rx_err tx_err
        Link detected: yes
bash-5.1# ethtool --version
ethtool version 6.2

Tested the use case from #2794

bash-5.1# ethtool -S eth0
NIC statistics:
     tx_timeout: 0
     suspend: 0
     resume: 0
     wd_expired: 0
     interface_up: 1
     interface_down: 0
     admin_q_pause: 0
     reset_fail: 0
     bw_in_allowance_exceeded: 17
     bw_out_allowance_exceeded: 0
     pps_allowance_exceeded: 0
     conntrack_allowance_exceeded: 0
     linklocal_allowance_exceeded: 0
     conntrack_allowance_available: 76950
     queue_0_tx_cnt: 11387
     queue_0_tx_bytes: 1587195
     queue_0_tx_queue_stop: 0
     queue_0_tx_queue_wakeup: 0
     queue_0_tx_dma_mapping_err: 0
     queue_0_tx_linearize: 0
     queue_0_tx_linearize_failed: 0
     queue_0_tx_napi_comp: 17282
     queue_0_tx_tx_poll: 17593
     queue_0_tx_doorbells: 11222
     queue_0_tx_prepare_ctx_err: 0
     queue_0_tx_bad_req_id: 0
     queue_0_tx_llq_buffer_copy: 2029
     queue_0_tx_missed_tx: 0
     queue_0_tx_unmask_interrupt: 17282
     queue_0_tx_xsk_need_wakeup_set: 0
     queue_0_tx_xsk_wakeup_request: 0
     queue_0_rx_cnt: 124148
     queue_0_rx_bytes: 225658754
     queue_0_rx_rx_copybreak_pkt: 5130
     queue_0_rx_csum_good: 120904
     queue_0_rx_refil_partial: 0
     queue_0_rx_csum_bad: 0
     queue_0_rx_page_alloc_fail: 0
     queue_0_rx_skb_alloc_fail: 0
     queue_0_rx_dma_mapping_err: 0
     queue_0_rx_bad_desc_num: 0
     queue_0_rx_bad_req_id: 0
     queue_0_rx_empty_rx_ring: 0
     queue_0_rx_csum_unchecked: 3221
     queue_0_rx_xdp_aborted: 0
     queue_0_rx_xdp_drop: 0
     queue_0_rx_xdp_pass: 0
     queue_0_rx_xdp_tx: 0
     queue_0_rx_xdp_invalid: 0
     queue_0_rx_xdp_redirect: 0
     queue_0_rx_lpc_warm_up: 0
     queue_0_rx_lpc_full: 0
     queue_0_rx_lpc_wrong_numa: 0
     queue_0_rx_xsk_need_wakeup_set: 0
     queue_0_rx_zc_queue_pkt_copy: 0
     ena_admin_q_aborted_cmd: 0
     ena_admin_q_submitted_cmd: 21
     ena_admin_q_completed_cmd: 21
     ena_admin_q_out_of_space: 0
     ena_admin_q_no_completion: 0

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@yeazelm yeazelm marked this pull request as draft February 24, 2023 04:06
Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/os/os.spec Outdated Show resolved Hide resolved
@yeazelm yeazelm marked this pull request as ready for review February 24, 2023 16:06
packages/ethtool/ethtool.spec Outdated Show resolved Hide resolved
packages/ethtool/ethtool.spec Outdated Show resolved Hide resolved
packages/ethtool/ethtool.spec Show resolved Hide resolved
packages/ethtool/ethtool.spec Outdated Show resolved Hide resolved
packages/ethtool/ethtool.spec Outdated Show resolved Hide resolved
packages/ethtool/ethtool.spec Outdated Show resolved Hide resolved
packages/ethtool/ethtool.spec Outdated Show resolved Hide resolved
packages/ethtool/ethtool.spec Show resolved Hide resolved
This adds ethtool to all variants.
Co-authored-by: Ben Cressey <ben@cressey.org>
@yeazelm yeazelm merged commit cd9e139 into bottlerocket-os:develop Mar 2, 2023
@yeazelm yeazelm deleted the ethtool branch March 2, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants