Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsys: Add support for k8s workloads #2830

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

ecpullen
Copy link
Contributor

Issue number:

Closes #2515

Description of changes:

Enables workload testing with TestSys.
Note: The workload agent must be used with a custom build workload agent image from https://github.com/bottlerocket-os/bottlerocket-test-system/tree/d2f62a070a1642ce8c073e282434d7c189f2ad6e

Testing done:

Ran cargo make -e TESTSYS_TEST=workload test

In Test.toml

[aws]
workloads = { smoke-test = "<URI-TO-SMOKE-TEST-IMAGE>" }

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@ecpullen ecpullen force-pushed the workload branch 2 times, most recently from e33772b to a414cab Compare February 24, 2023 20:47
@ecpullen ecpullen changed the title testsys: Addd support for k8s workloads testsys: Add support for k8s workloads Feb 24, 2023
@ecpullen
Copy link
Contributor Author

^ Add documentation to TESTING.md

TESTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -193,6 +193,12 @@ impl CrdCreator for AwsEcsCreator {
Ok(CreateCrdOutput::NewCrd(Box::new(Crd::Test(test_crd))))
}

async fn workload_crd<'a>(&self, _test_input: TestInput<'a>) -> Result<CreateCrdOutput> {
Err(error::Error::Invalid {
what: "Workload testing is not supported for non-k8s variants".to_string(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, will adding ECS be a follow on from this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Ecs workload testing will be available after TestSys 0.0.6 is out.

@ecpullen ecpullen merged commit 502f9c1 into bottlerocket-os:develop Mar 1, 2023
@ecpullen ecpullen deleted the workload branch March 1, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testsys: run nvidia smoke test with cargo make test
3 participants