Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: ensure 'prepare-boot' runs after 'mark-successful-boot' #2873

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

etungsten
Copy link
Contributor

Issue number:

Closes #

Description of changes:

    release: ensure 'prepare-boot' runs after 'mark-successful-boot'
    
    To prevent prairiedog from reading the GPT table while signpost is still
    writing to it during 'mark-successful-boot', we enforce strict ordering
    between the two services to ensure 'prepare-boot' runs after
    'mark-successful-boot' is fully active/finished.

Testing done:
Verified that prepare-boot.service runs after mark-successful-boot.service

....
         Starting Call signpost to mark the …r all required targets are met....
         Starting Bottlerocket data store migrator...
[  OK  ] Started ACPI event daemon.
[  OK  ] Mounted Kernel Development Sources (Read-Only).
         Mounting Kernel Development Sources (Read-Write)...
[  OK  ] Mounted Kernel Development Sources (Read-Write).
[  OK  ] Finished Call signpost to mark the …ter all required targets are met..
         Starting Prepare Boot Directory (/boot)...
...

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

To prevent prairiedog from reading the GPT table while signpost is still
writing to it during 'mark-successful-boot', we enforce strict ordering
between the two services to ensure 'prepare-boot' runs after
'mark-successful-boot' is fully active/finished.
@etungsten etungsten merged commit 0ff60ff into bottlerocket-os:develop Mar 9, 2023
@etungsten etungsten deleted the booooot branch March 9, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants