Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsys: Update testsys to v0.0.7 #3065

Merged
merged 1 commit into from
May 2, 2023

Conversation

ecpullen
Copy link
Contributor

@ecpullen ecpullen commented May 1, 2023

Issue number:

Closes #N/A

Description of changes:

Update the TestSys library version to v0.0.7 - https://github.com/bottlerocket-os/bottlerocket-test-system/releases/tag/v0.0.7

Testing done:

Tested cargo make test.

Every 2.0s: testsys --kubeconfig /home/ec2-user/bottlerocket/testsys.kubeconfig status                                                                                         Mon May  1 17:59:38 2023

 NAME                                  TYPE                  STATE                             PASSED              FAILED              SKIPPED   BUILD ID              LAST UPDATE
 k-test-3-quick                        Test                  running                                1                   0                 6972   752a994d              2023-05-01T17:59:29Z
 k-test-3                              Resource              completed                                                                           752a994d              2023-04-30T21:02:06Z
 k-test-3-instances-jlro               Resource              completed                                                                           752a994d              2023-05-01T17:58:16Z

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@ecpullen ecpullen force-pushed the testsys-007 branch 4 times, most recently from 0302745 to 3483e41 Compare May 1, 2023 18:40
Comment on lines +86 to +88
# TestSys uses a newer version of base64 and serde_yaml
{ name = "testsys-model", version = "=0.0.7" },
{ name = "bottlerocket-types", version = "=0.0.7" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we skip-tree the older versions rather than the newer ones? I find it more useful to consider what's holding us back from upgrading vs. tracking where we're already on new versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several issues with TestSys 0.0.7 due to our change from openssl to rustls. This includes base64, serde_yaml, thiserror, json_patch and possibly others. Is it worth explicitly calling each one out?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fair to assume that testsys dependencies will be as current as possible, if we're following the same methodology there, so skipping the tree here makes sense to avoid duplication of effort.

@ecpullen ecpullen merged commit f6bd1f0 into bottlerocket-os:develop May 2, 2023
37 checks passed
@ecpullen ecpullen deleted the testsys-007 branch May 2, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants