Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s 1.27: remove defaults for kube-api-burst and kube-api-qps #3094

Merged

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented May 9, 2023

Issue number:

Closes #

Description of changes:

Removes the default value for kube-api-burst and kube-api-qps

In K8s 1.27, the defaults were increased kubernetes/kubernetes#116121 to 50/100 which is even higher, so we can rely on those defaults now.

Testing done:

cargo make \
  -e BUILDSYS_VARIANT="aws-k8s-1.27" \
  -e BUILDSYS_ARCH="x86_64" \
  unit-tests

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@stmcginnis stmcginnis changed the title remove the defaults for kube-api-burst and kube-api-qps k8s 1.27: remove defaults for kube-api-burst and kube-api-qps May 9, 2023
Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending some additional testing results.

Copy link
Contributor

@etungsten etungsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Tested changes in a 1.27 node. Node joins cluster successfully and no longer explicitly sets defaults for kube-api-burst and kube-api-qps

@etungsten etungsten merged commit 9cd5929 into bottlerocket-os:develop May 9, 2023
43 checks passed
@tzneal tzneal deleted the remove-qps-limits-for-1.27 branch May 10, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants