update SDK to 0.33.0 #3213
Merged
update SDK to 0.33.0 #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please revert ee7205d in this PR. We had to pin the node's rust version temporarily, otherwise the cargo index format was getting a mismatch between the 1.69 format and the newer 1.70 sparse format. Once we move to 1.70 in the SDK, we can remove that pin so the host gets the |
Signed-off-by: Ben Cressey <bcressey@amazon.com>
Signed-off-by: Ben Cressey <bcressey@amazon.com>
This causes the RPM package architecture to match the target's rather than the host's. By default, `dnf` and `rpm` will ignore non-native RPMs, but both can be forced to use them. When the package architecture is set correctly, it's not necessary to include the architecture in the package name, and the macros in the SDK no longer do so. Fix up various places in the image build process that assumed the architecture would be present. Signed-off-by: Ben Cressey <bcressey@amazon.com>
This was used as a quick way to disable debuginfo generation, but it creates ambiguity when using the RPM's architecture to indicate what target the package was built for. These packages capture the architecture in the sysroot-based paths used for installed files, so they are not actually arch-agnostic in the sense that "noarch" implies. Signed-off-by: Ben Cressey <bcressey@amazon.com>
Signed-off-by: Ben Cressey <bcressey@amazon.com>
Signed-off-by: Ben Cressey <bcressey@amazon.com>
This reverts commit ee7205d. Pinning the Rust version is no longer required, now that Rust 1.70 is in the SDK and supports the new sparse index format by default.
bcressey
force-pushed
the
sdk-bump
branch
3 times, most recently
from
8e4aed7
to
7633bc0
Compare
etungsten
approved these changes
Jun 22, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Switch to the new SDK, which includes:
xfsprogsThe macro move requires some minor fixes. The most visible change will be that RPMs now have the architecture set correctly to the target's architecture, rather than including that in the package name. RPMs aren't directly user-facing except in the case of
application-inventory.json, which is now simpler to generate.I've also cleaned up packages that were (incorrectly) tagged as "noarch". This changes
application-inventory.jsonfor the affected packages, which move from"Architecture": "noarch"to the target's architecture.Testing done:
Built some variants:
I checked
application-inventory.jsonon the running instances and confirmed that the prefix was correctly matched and removed, and that the "Architecture" field was set to the target's architecture for all packages.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.