Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #1078
Description of changes:
This PR adds support for AppMesh in the ECS variant. The first-party patches to the ECS agent were regenerated, since a patch to remove the AppMesh CNI plugin from the list of supported CNI plugins was dropped. Thus, reviewers can ignore changes in patches 0001, 0003-0005.
In the packaging for the ECS agent, there is a patch to change the location of the log files created by the VPC CNI plugins (among other files). The VPC CNI plugins will ignore the default values for these log files if the environment variable
VPC_CNI_LOG_FILE
is set. The ECS agent does set this environment variable using the value overridden by the Bottlerocket patch. Thus, I decided to skip the creation of a patch similar to this, since even if the default log file location is changed, it won't have any effect. All CNI plugins will log to the same file inVPC_CNI_LOG_FILE
, which is/var/log/ecs/ecs-cni-bridge-plugin.log
in Bottlerocket.I'm planning to do more clean up in the patches that are carried along with some suggestions that were given for the ECS agent spec file. I'll do that after this PR is merged.
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.