update glibc to 2.38 #3355
Merged
update glibc to 2.38 #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmcginnis
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Did a quick sanity check. Built an aws-k8s-1.27 variant and joined to an EKS cluster. Node joined and reported healthy. All kube-system pods looked good and were in a Running state. Ran sonobuoy quick test which passed.
Nothing stood out as odd or obviously wrong in the updated patches. Looks good to me.
markusboehme
approved these changes
Aug 25, 2023
yeazelm
reviewed
Aug 25, 2023
Housekeeping changes: * Drop post-release patches for glibc 2.37, and add patches for 2.38. * Keep the `localedef` hack working with one more hack. * Remove unsupported configure options, and add new ones to disable building `nscd` rather than just excluding it from packaged files. * Include libmvec for all architectures, since it's now supported on aarch64. Functional changes: * `--enable-multi-arch` to include microarch-optimized functions in the same DSO. This trades off a small amount of disk space and RAM to provide optimized versions of some string and memory functions. (This feature was disabled by accident in the original packaging.) * `--enable-fortify-source` to build with the maximum supported level of `_FORTIFY_SOURCE` when possible. Currently, this is "2", but will be "3" when we update to GCC 12. Signed-off-by: Ben Cressey <bcressey@amazon.com>
|
⬆️ force pushes add recent patches (and fix a blunder with the local 9001 patch) |
yeazelm
approved these changes
Aug 29, 2023
markusboehme
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#3170
Description of changes:
Housekeeping changes:
localedefhack working with one more hack.building
nscdrather than just excluding it from packaged files.aarch64.
Functional changes:
--enable-multi-archto include microarch-optimized functions inthe same DSO. This trades off a small amount of disk space and RAM
to provide optimized versions of some string and memory functions.
(This feature was disabled by accident in the original packaging.)
--enable-fortify-sourceto build with the maximum supported levelof
_FORTIFY_SOURCEwhen possible. Currently, this is "2", butwill be "3" when we update to GCC 12.
Testing done:
Tested AWS and VMware variants, with this change alone and in combination with other recent commits. Nodes all came up healthy and ran containers.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.