Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: fix positional arguments for testsys #3379

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

webern
Copy link
Member

@webern webern commented Aug 30, 2023

Issue number:

Fixes a problem with #3342

N/A

Description of changes:

Testsys was broken because Twoliter was intercepting the -f in this command:

cargo make test -f /foo

This is because Clap didn't work the way we thought it did. This fixes the issue.

Testing done:

We checked all of the commands that use splatting of cargo make arguments (basically all of the the testsys makefile targets) to make sure testsys was being invoked correctly.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Testsys was broken because Twoliter was intercepting the -f in this
command:

cargo make test -f /foo

This is because Clap didn't work the way we thought it did. This fixes
the issue.
@webern
Copy link
Member Author

webern commented Aug 30, 2023

This build error appears unrelated to twoliter, assuming the other variant/arches pass:

ERROR: failed to solve: failed to authorize: failed to fetch oauth token: unexpected status from POST request to https://auth.docker.io/token: 503 Service Unavailable

@webern
Copy link
Member Author

webern commented Aug 30, 2023

Similar

 ERROR: failed to solve: pulling from host registry-1.docker.io failed with status code [manifests 1.4.3]: 503 Service Unavailable

@webern webern merged commit 0d65422 into bottlerocket-os:develop Aug 30, 2023
38 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants