-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate log4j-hotpatch OCI hook #3401
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
bcressey
reviewed
Sep 1, 2023
sources/api/migration/migrations/v1.15.0/deprecate-log4j-hotpatch-enabled/Cargo.toml
Outdated
Show resolved
Hide resolved
sources/api/migration/migrations/v1.15.0/log4j-hotpatch-enabled-metadata/Cargo.toml
Outdated
Show resolved
Hide resolved
The new settings will generate the configurations needed to log deprecation warning in the journal. Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
The hotdog OCI hooks are no longer needed now that the setting to hotpatch log4j is deprecated. Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
The log4j2 hotpatch is no longer needed now that the setting to hotpatch log4j is deprecated. Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
596ea34
to
5f7a28b
Compare
Forced push includes:
|
Tested the downgrade path for Downgrade to 1.14.3:
Upgrade to 1.15.0 again:
|
bcressey
approved these changes
Sep 2, 2023
yeazelm
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #3399
Description of changes:
Remove the log4j hotpatch functionality and deprecate the setting. Clean up unused packages.
Testing done:
In
aws-ecs-1
:log4j-hotpatch-enabled
settings was set totrue
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.