Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: Update to latest stable patch version 252.18 #3533

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

zmrow
Copy link
Contributor

@zmrow zmrow commented Oct 17, 2023

Issue number:
N/A

Description of changes:
Updates systemd to the latest stable patch version in the 252 chain: 252.18.

Testing done:
WIP

  • Ensure the build log contains no relevant warnings or warnings about patch offsets
  • Test spinning up large amounts (3k+) of pods in an ipv6-enabled cluster with systemd-networkd via aws-k8s-1.28 to regression test the issue fixed in Backport systemd patches and configure netlink timeout #3520 (instance loses ipv6 address because of timeout). Used 80 nodes and 5000 pods.
  • Test launches at scale (2000 nodes) for multiple instance types and network backends (wicked / systemd-networkd), ensure nodes are schedule-able and run pods
    • m5.large -> systemd-networkd
    • m5.large -> wicked
    • t3.medium -> systemd-networkd
    • t3.medium -> wicked
    • m6a.12xlarge -> systemd-networkd (could only get 800 of this instance type in my region)
    • m6a.12xlarge -> wicked (same here)

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@bcressey bcressey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the build output for the systemd package and make sure there are no warnings about patch offsets or warnings during the build?

packages/systemd/Cargo.toml Outdated Show resolved Hide resolved
@zmrow
Copy link
Contributor Author

zmrow commented Oct 18, 2023

^ Fixed the added newline in the Cargo.toml

@zmrow
Copy link
Contributor Author

zmrow commented Oct 18, 2023

Can you check the build output for the systemd package and make sure there are no warnings about patch offsets or warnings during the build?

Checked the build log and didn't find any relevent warnings or references to patch offsets! Also update the description

@zmrow zmrow marked this pull request as ready for review October 19, 2023 20:35
@zmrow zmrow requested a review from bcressey October 19, 2023 21:25
@zmrow zmrow merged commit 349ea05 into bottlerocket-os:develop Oct 23, 2023
46 checks passed
@zmrow zmrow deleted the systemd-update branch October 23, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants