Add kubernetes-1.29 package and variants #3628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etungsten
reviewed
Dec 21, 2023
|
New Kubernetes requires go1.21 or greater, and the go version at SDK 0.36.1 is 1.20. Therefore the CI build failed. Current We're working on bumping the Go version to 1.21. For the testing, I was using SDK 0.36.0 which has go1.21. |
etungsten
reviewed
Jan 2, 2024
gthao313
force-pushed
the
1.29
branch
2 times, most recently
from
5f13f8c
to
7a72c85
Compare
etungsten
approved these changes
Jan 2, 2024
bcressey
reviewed
Jan 3, 2024
|
^ addressed comments. I'll re-test it with new SDK. |
bcressey
reviewed
Jan 4, 2024
This adds a k8s-1.29 package. Existing 1.28 models are moved to be 1.29, with symlinks created for 1.28 models to point to the new locations. Finally, new variants are defined for aws-k8s-1.29, aws-k8s-1.29-nvidia, metal-k8s-1.29, and vmware-k8s-1.29.
|
Test result with new SKD metal-k8s vmware-k8s |
bcressey
approved these changes
Jan 8, 2024
arnaldo2792
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Description of changes:
This adds the package for K8s 1.29 for building kubelet and new 1.29 Bottlerocket variants.
Testing done:
Following the instruction Add kubernetes-1.28 package and variants #3329 (comment)
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.