Move template migrations to schnauzer v2 #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows migrations to link against schnauzer rather than needing to execute the binary.
This helps reduce the build time since the build system currently compiles everything in the migrations' directory.
This replaces ReplaceTemplateMigration with SchnauzerTemplateMigration, which uses the new template rendering machinery to perform the same behavior as the previous migrations.
cbgbt
force-pushed
the
schnauzer-v2-migrator
branch
from
e131ce9
to
560ac62
Compare
zmrow
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #3133
Description of changes:
The template migrator takes preventative steps to avoid overwriting user-provided settings or setting generators when they were initially generated by a setting generator. It does this by running the old generator and checking to see if the current value is a match (implying it has not been overwritten) before taking action.
The concept of "template metadata" disappears with schnauzer-v2, leaving behind a binary invocation which includes template information. This PR changes the schnauzer-v2 CLI to become a library that we can link against and invoke in migrations.
The previous schnauzer migration lives on (but deprecated) until such a time that we can archive all migrations that depend on it.
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.