Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pluto: remove unnecessary auth header in hyper-proxy #3667

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

etungsten
Copy link
Contributor

@etungsten etungsten commented Dec 8, 2023

Issue number:
N/A

Description of changes:
We should only need the proxy auth header to talk to the proxy when proxying.

Testing done:
Launched instance with https_proxy setting:

[settings.network]
https-proxy = "http://user:pass@proxy:port"

Cloudtrail shows the describe instance originating from pluto going through my proxy:

    "eventTime": "2023-12-08T04:09:29Z",
    "eventSource": "ec2.amazonaws.com",
    "eventName": "DescribeInstances",
    "awsRegion": "us-west-2",
    "sourceIPAddress": "my_proxy",
    "userAgent": "aws-sdk-rust/0.55.3 os/linux lang/rust/1.74.0",

Without the https_proxy setting, the source of the event is my instance public IP as expected:


    "eventSource": "ec2.amazonaws.com",
    "eventName": "DescribeInstances",
    "awsRegion": "us-west-2",
    "sourceIPAddress": "my_instance_pub_ip",
    "userAgent": "aws-sdk-rust/0.55.3 os/linux lang/rust/1.74.0",

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@rpkelly rpkelly self-requested a review December 8, 2023 01:02
Copy link
Member

@jpculp jpculp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending testing.

@etungsten etungsten changed the title pluto: remove unnecessary code paths in hyper-proxy pluto: remove unnecessary auth header in hyper-proxy Dec 8, 2023
@etungsten etungsten marked this pull request as ready for review December 8, 2023 04:17
We should only need the proxy auth header to talk to the proxy when
proxying.
@etungsten etungsten merged commit a7be9c3 into bottlerocket-os:develop Dec 8, 2023
46 checks passed
@etungsten etungsten deleted the huhcat branch December 8, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants