Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selinux-policy: remove unused entry #3673

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

yeazelm
Copy link
Contributor

@yeazelm yeazelm commented Dec 15, 2023

We don't invoke runc directly but rather through host-ctr, containerd, or docker so this line isn't doing anything. This cleans up the line to be more clear that we don't actually need this rule. In fact, it was pointing to a different location than where runc resides.

Testing done:
Built an aws-k8s-1.28 image and confirmed it could launch host containers and orchestrated containers.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

We don't invoke runc directly but rather through host-ctr, containerd,
or docker so this line isn't doing anything. This cleans up the line to
be more clear that we don't actually need this rule. In fact, it was
pointing to a different location than where runc resides.
@arnaldo2792
Copy link
Contributor

arnaldo2792 commented Dec 21, 2023

Have you tried upgrade/downgrade testing?

I was pointed out that this path never existed

@yeazelm yeazelm merged commit bd8a944 into bottlerocket-os:develop Dec 22, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants