settings: add container-registry settings extension
#3674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-berning
force-pushed
the
registry-settings-extension
branch
from
ec438b2
to
3cb1e6c
Compare
Signed-off-by: Sam Berning <bernings@amazon.com>
Signed-off-by: Sam Berning <bernings@amazon.com>
Signed-off-by: Sam Berning <bernings@amazon.com>
sam-berning
force-pushed
the
registry-settings-extension
branch
from
3cb1e6c
to
374f7b2
Compare
etungsten
approved these changes
Dec 21, 2023
arnaldo2792
approved these changes
Dec 22, 2023
|
@sam-berning Just to confirm, this has no end-user impact on the setting? We don't need to change the docs as outlined here: https://bottlerocket.dev/en/os/1.17.x/api/settings/container-registry/ |
|
Yep, that's right |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes # #3658
Description of changes:
Ports
container-registrysettings to a settings extension. Creates a basic binary for the extension and a package that can install it.Testing done:
aws-devvariant with thesettings-container-registrypackage includedapiclient set -j '{"container-registry": {"mirrors": [{"registry": "foo", "endpoint": ["bar"]}]}'/usr/libexec/settings/container-registryworked as expectedTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.