prairiedog: migrate to config file #3713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbgbt
reviewed
Jan 18, 2024
There was a problem hiding this comment.
Cool! For some feedback on git style:
- I would squash
prairiedog: fix source number to match with other templatesto be included in the same commit that modified the RPM. - We tend to leave PR/fixup style comments to the PRs themselves, and the commit messages just focus on the unique change made in that commit. For consistency, it would be best to remove the
fixup!lines.
sources/api/migration/migrations/v1.18.1/prairiedog-config-file-v0-1-0/src/main.rs
Outdated
Show resolved
Hide resolved
jmt-lab
force-pushed
the
jmt/prairiedog/config-file
branch
from
4aaf97d
to
9714943
Compare
|
squashed commits and updated changes via comments |
bcressey
reviewed
Jan 25, 2024
webern
requested changes
Feb 5, 2024
sources/api/migration/migrations/v1.18.1/prairiedog-config-file-v0-1-0/src/main.rs
Outdated
Show resolved
Hide resolved
sources/api/migration/migrations/v1.18.1/prairiedog-config-file-v0-1-0/src/main.rs
Outdated
Show resolved
Hide resolved
jmt-lab
force-pushed
the
jmt/prairiedog/config-file
branch
from
9714943
to
54edd28
Compare
|
Rebased off latest |
jmt-lab
force-pushed
the
jmt/prairiedog/config-file
branch
from
54edd28
to
5af8abe
Compare
|
Adjust spaces in template |
webern
requested changes
Feb 7, 2024
|
Let's merge this first #3768 then rebase your PR to align on 1.19.2 |
jmt-lab
force-pushed
the
jmt/prairiedog/config-file
branch
2 times, most recently
from
1f8500c
to
4eab3cf
Compare
|
Rebased off latest |
webern
requested changes
Feb 15, 2024
There was a problem hiding this comment.
Ben's comments are blocking as well as my request that you remove the dependency on models. For future reference, removing the dependency on models is the reason we are doing this. If we forgot to do that on the previously merged PR, please do a follow up. Thanks!
jmt-lab
force-pushed
the
jmt/prairiedog/config-file
branch
5 times, most recently
from
f708642
to
fe6b525
Compare
|
Models dependency removed |
webern
requested changes
Feb 20, 2024
jmt-lab
force-pushed
the
jmt/prairiedog/config-file
branch
from
fe6b525
to
8875dca
Compare
webern
approved these changes
Feb 20, 2024
jmt-lab
force-pushed
the
jmt/prairiedog/config-file
branch
from
8875dca
to
170bb08
Compare
|
rebased off latest |
bcressey
approved these changes
Feb 28, 2024
packages/os/prairiedog-toml
Outdated
Comment on lines
4
to
13
| {{#if settings.boot}} | ||
| {{#if settings.boot.reboot-to-reconcile}} | ||
| reboot-to-reconcile = {{settings.boot.reboot-to-reconcile}} | ||
|
|
||
| {{/if}} | ||
| {{#if settings.boot.kernel}} | ||
| [kernel] | ||
| {{#each settings.boot.kernel}} | ||
| "{{@key}}" = [ {{#each this}}"{{{this}}}",{{/each}} ] | ||
| {{/each}} | ||
|
|
||
| {{/if}} |
There was a problem hiding this comment.
Does this render a config file with two empty lines if none of the settings are present?
Changes prairiedog to read from /etc/prairiedog.toml which is generated automatically from the settings.
jmt-lab
force-pushed
the
jmt/prairiedog/config-file
branch
from
170bb08
to
efa092b
Compare
bcressey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #3622
Closes #3622
Description of changes:
Testing done:
Fully tested migration upgrade and the reboot logic for the reconcile works. Also made sure kernel settings synced to the file
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.